(fix) O3-2596: Fix for Allergy Set Mapping Errors #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibacher
approved these changes
Mar 12, 2024
gracepotma
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to quite a few actions to remove and re-add the Allergy Parent Set concept and re-trigger an expansion, the version update of Allergy Collection v5 now fixes the 3 mappings that were not working properly.
Previously: seeing mapping error messages in OCL Admin: Cannot save mapping https://api.openconceptlab.org/orgs/openmrs/sources/AllergyParentConcepts/mappings/3/ [CAUSE]: Column 'uuid' cannot be null
With this PR: No more mapping-related error messages. Confirmed via subscription tests in both o3 and dev3.
However, still need to address this error message: "Cannot import concept 1067AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA, tried: Retrying import of concept 1067AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA after failure due to ''Concept #178' failed to validate with reason: conceptMappings[4]: Cannot map a reference term multiple times to the same concept' [CAUSE]: 'Concept #178' failed to validate with reason: conceptMappings[4]: Cannot map a reference term multiple times to the same concept"
Funny thing is there's no "Concept #178" associated with Concept 1067AAA My best guess is that there's some other collection with that concept and they are clashing. Will follow up on this and update this PR accordingly.