O3-2592: OCL file version bumps + update exports to match OCL standard #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details from issue https://issues.openmrs.org/browse/O3-2592: * Problem Background: Multiple O3 devs like [~ibacher] and [~samuel34] have been reporting various metadata challenges in the last ~2 months. Concepts keep appearing to be missing, when they should in fact be in the ocl config directory. I believe this ticket should fix that issue - here is what I believe the cause is: * Suspected Cause: OCL changed their export file naming conventions a few weeks ago ([discussed here|OpenConceptLab/ocl_issues#1595]) * Testing Process: We thought maybe the issue is that some subscriptions have silent errors not being noticed since we are not using the Subscription Module UI for the usual O3 RefApp builds. So I tried manually subscribing test3 to collections that we already have in the RefApp. To my surprise I noticed that all the dictionaries that have the OLD naming convention in our OCL JSON exports (in the iniz config directory) are NOT uploading upon build time. But they DO work when I use the subscription workflow. I assume this is due to the name no longer matching what is available in OCL online and causing issues with the import / parsing by the OCL Module at some point. * Plan: I hope that by re-downloading and updating all the old-named /ocl JSON files, this will fix the issues folks are seeing. *Which need updating:* * BasicDrugs_2.20230127173123.zip * BasicLabTests_4.20230326222632.zip * CCD_7.20230228121317.zip * CDU_3.0.20220817051630.zip * CIELImmunizationContent_6.20221017140334.zip * CIEL_severities.zip * CLF_4.20221222133544.zip * DemoPrograms_2.20220817052726.zip * DemoQueueConcepts_2.20220301052308.zip * GenericDemoForm_3.20220225043204.zip * PD_2.20230413171729.zip * SOAPTemplate_1.20230331074221.zip * VitalSignCodes_1.20230228084421.zip * procedures_5.20230405090039.zip Which are Okay / Have the latest Name: * openmrs_CIELAllergySet_v4_autoexpand-4.2023-11-08_052809.zip * openmrs_DrugDispense_v2_autoexpand-2.2023-07-13_181219.zip
gracepotma
changed the title
denniskigen
approved these changes
Nov 22, 2023
|
OK so, Dennis and I weren't 100% sure how best to test this on a local, so we are going to merge it and see what happens in the dev3 dev environment. If unexpected problems arise we can roll back. |
pirupius
deleted the
gracepotma-20231121-oclfilenamesupdateandversionbumps
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accomplishes 2 things:
Updates 2 dictionaries with trivial changes (a non-semantic change to Immunization Content to resolve error messages, and a simple update to Basic Lab Tests to add Missing Mappings for Serum Albumin)
Fix for issue https://issues.openmrs.org/browse/O3-2592:
Problem Background: Multiple O3 devs like @ibacher and @samuelmale have been reporting various metadata challenges in the last ~2 months. Concepts keep appearing to be missing, when they should in fact be in the ocl config directory. I believe this ticket should fix that issue - here is what I believe the cause is:
Suspected Cause: OCL changed their export file naming conventions a few weeks ago discussed here
Testing Process: We thought maybe the issue is that some subscriptions have silent errors not being noticed since we are not using the Subscription Module UI for the usual O3 RefApp builds. So I tried manually subscribing test3 to collections we already have in the RefApp. To my surprise I noticed that all the dictionaries that have the OLD naming convention in our OCL JSON exports (in the iniz config directory) are NOT uploading upon build time. But they DO work when I use the subscription workflow. I assume this is due to the name no longer matching what is available in OCL online and causing issues with the import / parsing by the OCL Module at some point.
Plan: I hope that by re-downloading and updating all the old-named /ocl JSON files, this will fix the issues folks are seeing.
METADATA CHANGES SUMMARY TABLE (original is here)
<style type="text/css"></style>