Skip to content

Commit

Permalink
Fix scikit-learn to <1.3, prepare post release (#215)
Browse files Browse the repository at this point in the history
  • Loading branch information
PGijsbers authored Jun 14, 2024
1 parent 0e5773f commit 96d05b1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions docs/source/releases.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
Release Notes
=============

Version 23.0.0.post1
--------------

Fix scikit-learn to version <1.3, because GAMA uses scikit-learn internals that were changed from 1.4.

Version 23.0.0
--------------
Expand Down
2 changes: 1 addition & 1 deletion gama/__version__.py
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
# format: YY.minor.micro
__version__ = "23.0.0"
__version__ = "23.0.0.post1"
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ requires-python = ">=3.9"
dependencies = [
"numpy>=1.20.0",
"scipy>=1.0.0",
"scikit-learn>=1.1.0",
"scikit-learn>=1.1.0,<1.3",
"pandas>=1.0",
"stopit>=1.1.1",
"liac-arff>=2.2.2",
Expand Down

3 comments on commit 96d05b1

@simonprovost
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PGijsbers Hi mate. I wondered what really is broken from 1.4 in GAMA other than the metrics management? Because if this so I am doing the PR in half an hour. I guess I managed to make it work for Sklearn > 1.4 but not yet 100% sure. Cheers!

@PGijsbers
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if other things broke, I did not have time to look into it. Most likely it's just that.

@simonprovost
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just managed to make it work with v. above 1.4 with a couple of changes but not much of a big deal. Good to know it is possible without major changes. I will keep this in mind.

Please sign in to comment.