Add an OpenLayers version selector to benchmarks #106
Merged
+1,807
−662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahow
force-pushed
the
ol-version-selector
branch
3 times, most recently
from
3b2f375 to
e57bb6f
Compare
The OL modules can be loaded from unpkg if a version other than the one in package.json is specified Also added an option in the benchmarks to select another OL version (only versions above 9.0 are supported)
jahow
force-pushed
the
ol-version-selector
branch
from
e57bb6f to
5050aaa
Compare
|
This is ready for review! @ronitjadhav |
ronitjadhav
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a version other than the default one is selected, OL modules are loaded from unpkg using an import map written at runtime.
This requires Vite to bundle the app as ES modules instead of a single bundle, so that we can redirect some modules to unpkg if needed
To do: