Fix type resolution in sub execution #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TextType, rather return ParameterType<Text> error message for EthereumAddress more useful
fforbeck
reviewed
Jan 16, 2020
| engine.execute(mainTemplate, TemplateParameters(), Map(TemplateSourceIdentifier(TemplateTitle("clause")) -> clauseTemplate,TemplateSourceIdentifier(TemplateTitle("clause")) -> clauseTemplate)) match { | ||
| case Right(result) => | ||
| val variable = VariableDefinition(VariableName("Parties"), Some(VariableTypeDefinition("Collection",Some(VariableTypeDefinition("Parefhuzegfty Info",None))))) | ||
| getCollection(variable, result, "") |
There was a problem hiding this comment.
What about adding an assert here to check if the returned type is indeed a collection value type with the expected values? If the returned collection is empty, should it break the test?
There was a problem hiding this comment.
The collection will be empty because the internal format value is an empty string.
The test here is more to check that the call actually works, there was an issue with this call previously
| } | ||
|
|
||
| def getCollection(variable:VariableDefinition, executionResult: TemplateExecutionResult, value:String):CollectionValue = { | ||
| println(variable.variableTypeDefinition) |
There was a problem hiding this comment.
I believe we can remove this println
fforbeck
approved these changes
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like when the parameter is not found, then the type returned is Text instead of ParameterType
This made issues in Collection definition.
This shows another issue that I need to look at but that's still an issue we need fixing
I'm not necessarily super happy with this solution (see #210 ) but it's clearly an improvement
This change is