fix: namespaced kruise-controller panic due to multiNamespaceCache
#1773
+60
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @hantmac |
hantmac
reviewed
Oct 3, 2024
pkg/controller/util/cache.go
Outdated
| switch informer.(type) { | ||
| case cache.SharedIndexInformer: | ||
| return informer.(cache.SharedIndexInformer).GetIndexer() | ||
| case toolscache.Informer: |
There was a problem hiding this comment.
This code will always match the toolscache.Informer case, because the function param type is toolscache.Informer.
Signed-off-by: joey <[email protected]>
chengjoey
force-pushed
the
fix/namespaced-controller
branch
from
273906e
to
b1cd825
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1773 +/- ##
==========================================
+ Coverage 47.91% 49.30% +1.39%
==========================================
Files 162 191 +29
Lines 23491 19616 -3875
==========================================
- Hits 11256 9672 -1584
+ Misses 11014 8686 -2328
- Partials 1221 1258 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
if set namespace, mgr will use
multiNamespaceCache, it useinformernotshardIndexInformerⅡ. Does this pull request fix one issue?
fix #1764
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews