fix sidecarset hash without image is calculated differently when changing image tag to latest
#1697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
kruise/apis/apps/defaults/v1alpha1.go
Lines 105 to 108 in 5a862a3
https://github.com/kubernetes/kubernetes/blob/60c4c2b2521fb454ce69dee737e3eb91a25e0535/pkg/apis/core/v1/defaults.go#L73-L78
when change image tag to
latest
, the sidecarset without image hash will be changedI think
ImagePullPolicy
should not be involved in the hash, because it will cause the hash to change, causing the pod not to to be upgradedⅡ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
change 1.19.6 to latest
This is the change I printed that participates in the hash calculation
IfNotPresent -> Always
Ⅳ. Special notes for reviews