-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: SpeedyWeather.jl: Reinventing atmospheric generic circulation models towards interactivity and extensibility #6323
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
Wordcount for |
|
Hi everyone! This is where the review will take place. Please open up issues in the software repo as they come up while you go through the review checklist (details above). Please get started in the next 1-2 weeks since the process is iterative with the author(s) and takes time to go back and forth sometimes. Let me know if you have any questions! |
Review checklist for @natgeo-wongConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @vavrinesConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Hi @vavrines, @natgeo-wong, @slayoo! I see some progress in these checklists, thanks for that! Feel free to open issues in the software repo as detailed questions come up and link them back to this review issue. Thanks. |
Review checklist for @slayooConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
I have submitted the issue in the in the software repo |
Are reviewers allowed to make pull requests to help with the stuff they have reviewed? |
Yes! This is ok. Ultimately when this package is uploaded to e.g. zenodo your username will be included in the author metadata but we ask that the metadata be overwritten to match the JOSS title and author list anyway. Thanks for your effort and enthusiasm!! |
@slayoo and @natgeo-wong how are your reviews coming along? @vavrines looks like you are having some good discussions — are you awaiting any specific comments or changes? |
Everything will be fine with me once SpeedyWeather/SpeedyWeather.jl#446 gets closed. |
I would refer @kthyng to SpeedyWeather/SpeedyWeather.jl#443, there's still quite a bit of work to be done especially re. documentation. |
@natgeo-wong No problem at all and I don't mean to pressure in any way — just wanted to make sure the opposite isn't happening where a review is forgotten. Thank you! |
Thanks for checking, yes, I've received comments from all reviewers and we're working on it! |
@editorialbot generate pdf |
@milankl That invalid DOI is on the MITgcm paper. Just remove the prefix. |
@editorialbot check references |
|
hm... I think the bot still looks in the branch -- I'm updating that! |
@editorialbot generate pdf |
@editorialbot check references |
|
@kthyng I fixed the doi now -- thanks |
@editorialbot generate pdf |
Ok I think that was everything! |
@editorialbot accept |
|
Ensure proper citation by uploading a plain text CITATION.cff file to the default branch of your repository. If using GitHub, a Cite this repository menu will appear in the About section, containing both APA and BibTeX formats. When exported to Zotero using a browser plugin, Zotero will automatically create an entry using the information contained in the .cff file. You can copy the contents for your CITATION.cff file here: CITATION.cff
If the repository is not hosted on GitHub, a .cff file can still be uploaded to set your preferred citation. Users will be able to manually copy and paste the citation. |
🐘🐘🐘 👉 Toot for this paper 👈 🐘🐘🐘 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations on your new publication @milankl! Many thanks to reviewers @vavrines, @natgeo-wong, and @slayoo for your time, hard work, and expertise!! JOSS wouldn't be able to function nor succeed without your efforts. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@milankl If you're interested in joining JOSS as a reviewer, please sign up here: https://reviewers.joss.theoj.org/! |
Woohoo @kthyng many thanks for editing this paper!! Much appreciated and thanks to the reviewers also from my side. Just signed up to be a reviewer too |
You're welcome! |
Submitting author: @milankl (Milan Klöwer)
Repository: https://github.com/SpeedyWeather/SpeedyWeather.jl
Branch with paper.md (empty if default branch): mk/josspaper
Version: v0.10
Editor: @kthyng
Reviewers: @vavrines, @natgeo-wong, @slayoo
Archive: 10.5281/zenodo.11474485
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@vavrines & @natgeo-wong & @slayoo, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kthyng know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @vavrines
📝 Checklist for @natgeo-wong
📝 Checklist for @slayoo
The text was updated successfully, but these errors were encountered: