Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge jdk #1282

Closed
wants to merge 76 commits into from
Closed

Merge jdk #1282

wants to merge 76 commits into from

Conversation

MrSimms
Copy link
Member

@MrSimms MrSimms commented Oct 19, 2024

Merge jdk-24+14


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1282/head:pull/1282
$ git checkout pull/1282

Update a local copy of the PR:
$ git checkout pull/1282
$ git pull https://git.openjdk.org/valhalla.git pull/1282/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1282

View PR using the GUI difftool:
$ git pr show -t 1282

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1282.diff

Webrev

Link to Webrev Comment

MBaesken and others added 30 commits August 29, 2024 07:07
Reviewed-by: jwaters, kbarrett, erikj
Reviewed-by: stuefe, gziemski
…ruction objects

Reviewed-by: asotona, redestad
Reviewed-by: stuefe, coleenp, dlong
…s implicitly declared classes

Reviewed-by: cstein, vromero
…IX and Linux ppc64le after JDK-8336856

Reviewed-by: redestad, mdoerr
…ssDefFoundErrorTest.java

Reviewed-by: dfuchs, dcubed
…ication for illegal symbols in suffix

Reviewed-by: alanb
… timeout intermittently

Reviewed-by: sspitsyn, amenkov
Co-authored-by: Magnus Ihse Bursie <[email protected]>
Co-authored-by: Jiangli Zhou <[email protected]>
Reviewed-by: prr, jiangli, alanb
Reviewed-by: djelinski, dfuchs
liach and others added 15 commits September 4, 2024 12:29
Reviewed-by: epeter, chagedorn, shade, qamai, jbhateja
Reviewed-by: matsaave, cjplummer, dlong, thartmann, yzheng
… on macOS

Move SelectCurrentItemTest.java to java/awt/Choice/SelectItem/.
Move SelectNewItemTest.java to java/awt/Choice/SelectItem/.
Use latches to control test flow instead of delays.
Encapsulate the common logic in SelectCurrentItemTest.
Provide overridable checkXXX() methods to modify conditions.
Provide an overridable method which defines where to click
in the choice popup to select an item.

Reviewed-by: honkar, prr, dnguyen
Reviewed-by: liach, redestad, jwaters, asotona
…ength 5

Co-authored-by: Dean Long <[email protected]>
Reviewed-by: kvn, thartmann
…a#id failed: Button renderings are different after window resize

Reviewed-by: honkar
…undErrorTest.java fails after JDK-8338257

Reviewed-by: jsjolen, coleenp
… 4294967295, which is not a valid value for type 'DepType'

Reviewed-by: stefank, kvn, dlong
@MrSimms
Copy link
Member Author

MrSimms commented Oct 19, 2024

/summary
Merge jdk-24+14

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2024

👋 Welcome back dsimms! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 19, 2024

@MrSimms This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Merge jdk

Merge jdk-24+14

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 19, 2024

@MrSimms Setting summary to Merge jdk-24+14

@mlbridge
Copy link

mlbridge bot commented Oct 19, 2024

Webrevs

@MrSimms
Copy link
Member Author

MrSimms commented Oct 19, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 19, 2024

Going to push as commit 88b2b86.

@openjdk openjdk bot added the integrated label Oct 19, 2024
@openjdk openjdk bot closed this Oct 19, 2024
@openjdk
Copy link

openjdk bot commented Oct 19, 2024

@MrSimms Pushed as commit 88b2b86.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.