8342276: [lworld] Apply LIBRARY.properties to stabiliize --enable-preview for tests #1280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create LIBRARY.properties files to set the value of
enablePreview
for sensitive test library roots.The top level test library is set with
enablePreview = false
so that when compiled they will be able to be used with or without enablePreview.Individual tests that use preview features and test library files that use preview features will need to be compiled based on the settings in each test.
Some tests are modified to remove explicit building or compilation and fall back to implicit compiles with the prevailing enablePreview setting.
There are other test library roots that declare
enablePreview = true
appropriate to their uses.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1280/head:pull/1280
$ git checkout pull/1280
Update a local copy of the PR:
$ git checkout pull/1280
$ git pull https://git.openjdk.org/valhalla.git pull/1280/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1280
View PR using the GUI difftool:
$ git pr show -t 1280
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1280.diff