Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() #197

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nelanbu
Copy link
Contributor

@nelanbu nelanbu commented Oct 18, 2024

Hi all,

This pull request contains a backport of commit 90c944fe from the openjdk/jdk repository.

The change applied cleanly.

The commit being backported was authored by Roland Westrelin on 2 Oct 2024 and was reviewed by Vladimir Ivanov and Quan Anh Mai.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8340824 needs maintainer approval

Issue

  • JDK-8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/197/head:pull/197
$ git checkout pull/197

Update a local copy of the PR:
$ git checkout pull/197
$ git pull https://git.openjdk.org/jdk23u.git pull/197/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 197

View PR using the GUI difftool:
$ git pr show -t 197

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/197.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2024

👋 Welcome back nelanbu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 90c944fefe4a7827c08a8e6a81f137c3157a749b 8340824: C2: Memory for TypeInterfaces not reclaimed by hashcons() Oct 18, 2024
@openjdk
Copy link

openjdk bot commented Oct 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

⚠️ @nelanbu This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2024

Webrevs

@nelanbu
Copy link
Contributor Author

nelanbu commented Oct 18, 2024

/approval request Clean backport to fix memory reclamation issue for TypeInterfaces object by hashcons().

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

@nelanbu
8340824: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant