Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337851: Some tests have name which confuse jtreg #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

toshiogata
Copy link

@toshiogata toshiogata commented Oct 18, 2024

Hi all,

I would like to backport this patch as the reported jtreg issue is reproducible in JDK23u.
The original patch applies cleanly.

Testing: the related tests with "-retain:all" option, and all tests under tools/javac

Thank you


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337851 needs maintainer approval

Issue

  • JDK-8337851: Some tests have name which confuse jtreg (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/194/head:pull/194
$ git checkout pull/194

Update a local copy of the PR:
$ git checkout pull/194
$ git pull https://git.openjdk.org/jdk23u.git pull/194/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 194

View PR using the GUI difftool:
$ git pr show -t 194

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/194.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2024

👋 Welcome back toshiogata! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e6698f51a1977d553ce4e1dd14b43b0d325224fa 8337851: Some tests have name which confuse jtreg Oct 18, 2024
@openjdk
Copy link

openjdk bot commented Oct 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

⚠️ @toshiogata This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2024

Webrevs

@toshiogata
Copy link
Author

/approval request I would like to backport this patch as the issue is reproducible in JDK23u. The patch applies cleanly. The risk is low as this only touches tests. Testing: the related tests with "-retain:all" option, and all tests under tools/javac

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

@toshiogata
8337851: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant