8341966: Broken annotated module may lead to an exception in javac

[lahodaj]

Hi all,

This pull request contains a backport of commit [7ff4ea8d](https://github.com/openjdk/jdk/commit/7ff4ea8d01c681b90ad59be04007557d84c8db94) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Jan Lahoda on 17 Oct 2024 and was reviewed by Adam Sotona.

Thanks!

The original description:

Consider a module-info.class, that both:

• is wrong, so it will produce a bad-classfile error, for example due to an illegal requires transitive java.base;
• and the module is annotated

If the javac proceeds to resolve the annotations (which is not the default, but can be pushed to do it), it will crash with an AssertionError while trying to un-proxy the annotations. This is because there's an assert that requestingOwner.owner.kind == MDL, but since the module is erroneous, the kind is ERR, and the assert fails.

The proposal is to loosen the assert a bit, and require requestingOwner.owner instanceof ModuleSymbol. That should still be sufficiently strong, while permitting broken modules to be handled.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8341966 needs maintainer approval

Issue

• JDK-8341966: Broken annotated module may lead to an exception in javac (Task - P4 - Approved)

Reviewers

• Adam Sotona (@asotona - no project role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/192/head:pull/192
$ git checkout pull/192

Update a local copy of the PR:
$ git checkout pull/192
$ git pull https://git.openjdk.org/jdk23u.git pull/192/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 192

View PR using the GUI difftool:
$ git pr show -t 192

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/192.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @lahodaj This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 01: Full - Incremental (0f468423)
• 00: Full (9f8a9db7)

[lahodaj]

/approval request This problem crashes javac with an exception when working with erroneous module-info.class. javac should report an error (and it does) but should not crash. The fix is just to down-tune an assert, so it should be very safe. Thanks!

[openjdk]

@lahodaj
8341966: The approval request has been created successfully.

[asotona]

Looks good to me.