Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340313: Crash due to invalid oop in nmethod after C1 patching #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Oct 17, 2024

Hi all,

This pull request contains a backport of commit 58d39c31 from the openjdk/jdk repository.

The change did not apply cleanly due to differences in src/hotspot/cpu/riscv/nativeInst_riscv.cpp.

The commit being backported was authored by Tobias Hartmann on 17 Oct 2024 and was reviewed by Thomas Schatzl, Vladimir Kozlov and Dean Long.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8340313 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8340313: Crash due to invalid oop in nmethod after C1 patching (Bug - P2 - Requested)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk23u.git pull/189/head:pull/189
$ git checkout pull/189

Update a local copy of the PR:
$ git checkout pull/189
$ git pull https://git.openjdk.org/jdk23u.git pull/189/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 189

View PR using the GUI difftool:
$ git pr show -t 189

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk23u/pull/189.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2024

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 58d39c317e332fda994f66529fcd1a0ea0e53151 8340313: Crash due to invalid oop in nmethod after C1 patching Oct 17, 2024
@openjdk
Copy link

openjdk bot commented Oct 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport approval rfr Pull request is ready for review labels Oct 17, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2024

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TobiHartmann
Copy link
Member Author

Thanks Christian!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants