8344199: Incorrect excluded field value set by getEventWriter intrinsic

[TobiHartmann]

The C2 intrinsic for jdk.jfr.internal.JVM::getEventWriter sets a boolean excluded field by masking the most significant bit of the unsigned 2-byte thread_epoch_raw field value. A shift is needed to get a proper boolean value.

Thanks,
Tobias

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344199: Incorrect excluded field value set by getEventWriter intrinsic (Bug - P3)

Reviewers

• SendaoYan (@sendaoYan - Committer)
• Markus Grönlund (@mgronlun - Reviewer)

Contributors

• Patricio Chilano Mateo <[email protected]>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22195/head:pull/22195
$ git checkout pull/22195

Update a local copy of the PR:
$ git checkout pull/22195
$ git pull https://git.openjdk.org/jdk.git pull/22195/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22195

View PR using the GUI difftool:
$ git pr show -t 22195

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22195.diff

Using Webrev

Link to Webrev Comment

[TobiHartmann]

/contributor add @pchilano

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344199: Incorrect excluded field value set by getEventWriter intrinsic

Co-authored-by: Patricio Chilano Mateo <[email protected]>
Reviewed-by: syan, mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• b8b70c8: 8344379: [s390x] build failure due to missing change from JDK-8339466
• 5fc4322: 8288298: Resolve multiline message parsing ambiguities in UL
• ea8f289: 8344271: Comparison build fails due to difference in doc summary
• b9c6ce9: 8344122: IGV: Extend c2 IdealGraphPrinter to send subgraphs to IGV
• 00ff6a3: 8344105: Remove SecurityManager and related calls from jdk.attach and jdk.hotspot.agent
• 475feb0: 8344056: Use markdown format for man pages
• 6c2ae44: 8344204: IGV: Button to enable/disable cutting of long edges
• 4a7ce1d: 8344205: [PPC]: failing assertion: sharedRuntime_ppc.cpp:1652: cookie not found
• b6c2122: 8316151: [macos14] ActionListenerCalledTwiceTest.java fails on macOS 14
• 543e355: 8344298: Test tools/sincechecker/modules/jdk.hotspot.agent/JdkHotspotAgentCheckSince.java fails on platforms without sa
• ... and 1 more: https://git.openjdk.org/jdk/compare/a47d9ba98a1498425970613415ecb830f805a3be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@TobiHartmann
Contributor Patricio Chilano Mateo <[email protected]> successfully added.

[openjdk]

@TobiHartmann The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4055bb96)

[sendaoYan]

Test passed after apply the patch of this PR

[mgronlun]

Thanks for finding and fixing this.

[TobiHartmann]

Thanks for the quick reviews!