Turn compiler plugin into simple SPI

[mcimadamore]

This PR is a small followup to the changes to turn compiler code reflection support into a compiler plugin.
Turns out that the new plugin required several hacks and workaround, to make sure that the plugin would only run when strictly required (not to affect outcome of compilation if the plugin was disabled). We can get rid of all such workarounds by turning the plugin into a plain and simple SPI. There is a new ReflectMethodsProxy interface, which is implemented by the new module (see ReflectMethods.Provider). This allows javac to more or less call into the new pipeline step as it did before the incubating change, which leads to code that is much simpler to maintain.

---

Progress

• Change must not contain extraneous whitespace

Reviewers

• Paul Sandoz (@PaulSandoz - Reviewer) ⚠️ Review applies to 016323db

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/275/head:pull/275
$ git checkout pull/275

Update a local copy of the PR:
$ git checkout pull/275
$ git pull https://git.openjdk.org/babylon.git pull/275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 275

View PR using the GUI difftool:
$ git pr show -t 275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/275.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mcimadamore! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mcimadamore This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Turn compiler plugin into simple SPI

Reviewed-by: psandoz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the code-reflection branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the code-reflection branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (f9ed4ac2)
• 00: Full (016323db)

[PaulSandoz]

Perhaps we should rename ReflectMethodsProxy to CodeReflectionTransformer use similar naming?

[mcimadamore]

/integrate

[openjdk]

Going to push as commit 152f4678c2ec50d5bbff04d76be7b007676b39e7.

[openjdk]

@mcimadamore Pushed as commit 152f467.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.