-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Zendesk #2217
Support for Zendesk #2217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! ❤️
I am happy to help in testing validation as I have an account with Zendesk that is used for Open-source project testing.
Yes please! (I don't have a Zendesk account and won't be able to test it myself)
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationProviders.xml
Outdated
Show resolved
Hide resolved
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationProviders.xml
Outdated
Show resolved
Hide resolved
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationProviders.xml
Outdated
Show resolved
Hide resolved
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationProviders.xml
Outdated
Show resolved
Hide resolved
Hey @mozts2005, If you have any question or need help to complete this PR, please let me know 😃 Cheers. |
I made the changes you requested. Line 200 in ff752ef
But I was thinking that if you wanted this could be added as a new EndpointAuthMethod if you prefer. Next, I added some mappings for to the UserInfo based on Zendesk endpoint results but if you would like I can remove them or add more. |
No that's fine 👍🏻 |
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationHandlers.cs
Outdated
Show resolved
Hide resolved
Thanks. Could you please attach a screenshot of the returned claims (visible in the output generated by the console client sandbox)? Feel free to blur out personal/sensitive details. Were you able to test everything? Revocation works fine? |
…t to the Authorization header
I pushed a commit that removes the |
src/OpenIddict.Client.WebIntegration/OpenIddictClientWebIntegrationHandlers.Userinfo.cs
Outdated
Show resolved
Hide resolved
…ationHandlers.Userinfo.cs
Merged. Thanks a lot for your contribution, @mozts2005! 👏🏻 |
I have added Support for Zendesk. I am happy to help in testing validation as I have an account with Zendesk that is used for Open-source project testing.