Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Zendesk #2217

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Support for Zendesk #2217

merged 5 commits into from
Nov 22, 2024

Conversation

mozts2005
Copy link
Contributor

I have added Support for Zendesk. I am happy to help in testing validation as I have an account with Zendesk that is used for Open-source project testing.

Copy link
Member

@kevinchalet kevinchalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! ❤️

I am happy to help in testing validation as I have an account with Zendesk that is used for Open-source project testing.

Yes please! (I don't have a Zendesk account and won't be able to test it myself)

@kevinchalet
Copy link
Member

Hey @mozts2005,

If you have any question or need help to complete this PR, please let me know 😃

Cheers.

@mozts2005
Copy link
Contributor Author

I made the changes you requested.
I also added support for revocation of the token.
Please let me know if you would like to handle the revocation authentication differently. I did it this way as the same type of override is done for the Trovo userinfo endpoint authentication.

request.Headers.Authorization = new AuthenticationHeaderValue("OAuth",

But I was thinking that if you wanted this could be added as a new EndpointAuthMethod if you prefer.

Next, I added some mappings for to the UserInfo based on Zendesk endpoint results but if you would like I can remove them or add more.

@kevinchalet
Copy link
Member

Please let me know if you would like to handle the revocation authentication differently.

No that's fine 👍🏻

@kevinchalet
Copy link
Member

Thanks. Could you please attach a screenshot of the returned claims (visible in the output generated by the console client sandbox)? Feel free to blur out personal/sensitive details.

Were you able to test everything? Revocation works fine?

@mozts2005
Copy link
Contributor Author

Thanks. Could you please attach a screenshot of the returned claims (visible in the output generated by the console client sandbox)? Feel free to blur out personal/sensitive details.

Were you able to test everything? Revocation works fine?

yes, revocation works and here is the screenshot.
ZendeskAfterUnwrap

@kevinchalet
Copy link
Member

I pushed a commit that removes the token parameter from the revocation request (since Zendesk doesn't expect it and requires using bearer authentication instead). Could you please give it a try to ensure it still works fine with this change?

@mozts2005
Copy link
Contributor Author

I pushed a commit that removes the token parameter from the revocation request (since Zendesk doesn't expect it and requires using bearer authentication instead). Could you please give it a try to ensure it still works fine with this change?

all changes made look good to me after testing.
image

@kevinchalet kevinchalet merged commit 9fbe030 into openiddict:dev Nov 22, 2024
3 checks passed
@kevinchalet
Copy link
Member

Merged. Thanks a lot for your contribution, @mozts2005! 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants