Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error #1798 #1800

Closed
wants to merge 8 commits into from
Closed

Fixed error #1798 #1800

wants to merge 8 commits into from

Conversation

greg-han
Copy link

Here is the link to the error.
#1798

I just deleted a word in the main.html file.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.568% when pulling cce7071 on greg-han:master into 18ad905 on openhatch:master.

@codecov-io
Copy link

codecov-io commented Dec 26, 2016

Current coverage is 78.56% (diff: 100%)

Merging #1800 into master will not change coverage

@@             master      #1800   diff @@
==========================================
  Files            70         70          
  Lines          5935       5935          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           4663       4663          
  Misses         1272       1272          
  Partials          0          0          

Powered by Codecov. Last update 18ad905...4de104e

@coveralls
Copy link

Coverage Status

Coverage remained the same at 78.568% when pulling 4de104e on greg-han:master into 18ad905 on openhatch:master.

@rafpaf
Copy link
Contributor

rafpaf commented Dec 28, 2016

Hey greg-han, thank you so much for looking into this! I had a look here on GitHub at the diff between your code and the openhatch master branch. It looks like there's more changes than just the typo fix. If you have a moment and could make another pull request, with just that one small change, that would be great.

Conflicts:
	mysite/missions/templates/missions/main.html
@greg-han
Copy link
Author

greg-han commented Dec 28, 2016 via email

@greg-han greg-han closed this Dec 28, 2016
@greg-han greg-han reopened this Dec 28, 2016
@greg-han greg-han closed this Dec 28, 2016
@greg-han greg-han reopened this Dec 28, 2016
Copy link

@eppeters eppeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @greg-han, I'm new here, but since nothing has happened on this for a few days, I figured I'd suggest a way to make it right.

There's still extra stuff in your fork's master branch. To fix this, you can destroy your fork on github, delete your local copy of the fork, re-fork this repo, re-clone your fork, and make only your typo fix, and make a new PR.

# You should have received a copy of the GNU Affero General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
# This file is part of OpenHatch.
# Copyright (C) 2009 OpenHatch, Inc.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think you meant to make this change.

@@ -173,3 +174,180 @@ <h3 class="up-top"><img alt='Training Missions' id='training-missions' alt='Trai
</div>
</div>
{% endblock main %}
=======
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge conflict markers were committed!

@@ -44,7 +45,7 @@ <h3 class="up-top"><img alt='Training Missions' id='training-missions' alt='Trai

<h2>Get to know about: "The Shell"</h2>

<p>These missions teach you about how to use the command line tool called as the "shell" and few basic commands which will help you in other missions.
<p>These missions teach you about how to use the command line tool called the "shell" and few basic commands which will help you in other missions.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is what you wanted to get in there.

@greg-han greg-han closed this Jan 5, 2017
@greg-han
Copy link
Author

greg-han commented Jan 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants