-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more types as output of thing actions #4435
Add support for more types as output of thing actions #4435
Conversation
...c/main/java/org/openhab/core/automation/internal/module/handler/AnnotationActionHandler.java
Outdated
Show resolved
Hide resolved
@florian-h05 : why not simply using this for all other types ?
This would avoid the warning "Non compatible return type" and would provide descent result for date or time types for example ? |
A. Not all data types implement proper I would rather only convert selected data types to string, those would be QuantityType, LocalTime, LocalDate, LocalDateTime, ZonedDateTime (we can add more, just to mention a few). |
612eabb
to
df9fdbd
Compare
Byte Short Long BigDecimal QuantityType LocalDate LocalTime LocalDateTime ZonedDateTime Instant Duration Signed-off-by: Laurent Garnier <[email protected]>
df9fdbd
to
8cdb914
Compare
@florian-h05 : I added few more types. Tested for each of them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment, otherwise LGTM.
...c/main/java/org/openhab/core/automation/internal/module/handler/AnnotationActionHandler.java
Outdated
Show resolved
Hide resolved
e584ac8
to
84e973e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks!
84e973e
to
774af21
Compare
Signed-off-by: Laurent Garnier <[email protected]>
774af21
to
9d03fc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Byte
Short
Long
BigDecimal
QuantityType
LocalDate
LocalTime
LocalDateTime
ZonedDateTime
Instant
Duration