Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse BigInteger directly in DecimalType #4417

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Parse BigInteger directly in DecimalType #4417

merged 2 commits into from
Oct 20, 2024

Conversation

magx2
Copy link
Contributor

@magx2 magx2 commented Oct 20, 2024

Instead of running expensive BigInteger.toString() and then parsing BigDecimal from it, run direclty constructor BigDecimal(BigInteger)

@magx2
Parse BigInteger directly in DecimalType
44b0f0a 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2 magx2 requested a review from a team as a code owner October 20, 2024 11:28
J-N-K
J-N-K approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Oct 20, 2024
@J-N-K J-N-K added this to the 4.3 milestone Oct 20, 2024
@J-N-K J-N-K merged commit 1325d80 into openhab:main Oct 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@magx2 @J-N-K