Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rest] Add channels to cacheable Things list #3761

Closed
wants to merge 1 commit into from
Closed

[rest] Add channels to cacheable Things list #3761

wants to merge 1 commit into from

Conversation

florian-h05
Copy link
Contributor

@florian-h05 florian-h05 commented Aug 17, 2023 •
edited
Loading

Fixes openhab/openhab-webui#1996.

For previous discussion about including channels, see #3335 (comment).

This should be backported to 4.0.x.

/cc @J-N-K

@florian-h05 florian-h05 requested a review from a team as a code owner August 17, 2023 15:47
ghys added a commit to openhab/openhab-webui that referenced this pull request Aug 17, 2023
@ghys
Update triggerchannel-picker.vue
339a0d8 
Fix #1996.

Better solution IMO than openhab/openhab-core#3761.

Signed-off-by: Yannick Schaus <[email protected]>
@ghys ghys mentioned this pull request Aug 17, 2023
Merged
@ghys
Copy link
Member

ghys commented Aug 18, 2023

I have created openhab/openhab-webui#2026 as an alternative to this PR.
Omitting detailed info from lists responses (i.e. channels from /rest/things and rule modules from /rest/rules) was the main purpose of the summary parameter before staticDataOnly was used, as it's the bulk of the responses and barely used in lists.
There's always the option of making exceptions to using the cache or the summary output, I think it makes sense for that one picker. See my last comment at #3335.

florian-h05 pushed a commit to openhab/openhab-webui that referenced this pull request Aug 18, 2023
@ghys
Fix channel for Thing trigger cannot be chosen (#2026)
3eff1fa 
Fixes #1996.
Regression from #1661.

Supersedes openhab/openhab-core#3761.

Signed-off-by: Yannick Schaus <[email protected]>
@florian-h05
Copy link
Contributor Author

I have just merged openhab/openhab-webui#2026, so this can be closed.

@florian-h05 florian-h05 deleted the things-cacheable-channels branch August 18, 2023 15:37
florian-h05 pushed a commit to openhab/openhab-webui that referenced this pull request Aug 19, 2023
@ghys @florian-h05
Fix channel for Thing trigger cannot be chosen (#2026)
a4badde 
Fixes #1996.
Regression from #1661.

Supersedes openhab/openhab-core#3761.

Signed-off-by: Yannick Schaus <[email protected]>
(cherry picked from commit 3eff1fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot choose channel when creating rule to trigger on Thing Event
2 participants
@florian-h05 @ghys