ZipException workarounds #3747
Merged
ZipException workarounds #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use Karaf 4.4.3 compile dependency * Disable this feature in itests Signed-off-by: Wouter Born <[email protected]>
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Aug 9, 2023
This prevents ZipException stacktraces when running the itests on JDK 17.0.8 or newer. Related to: * openhab/openhab-core#3718 * openhab/openhab-core#3747 Signed-off-by: Wouter Born <[email protected]>
wborn
added a commit
to wborn/openhab-addons
that referenced
this pull request
Aug 9, 2023
This prevents ZipException stacktraces when running the itests on JDK 17.0.8 or newer. Related to: * openhab/openhab-core#3718 * openhab/openhab-core#3747 Signed-off-by: Wouter Born <[email protected]>
J-N-K
added
the
external bug
wborn
added a commit
that referenced
this pull request
Aug 11, 2023
* Use Karaf 4.4.3 compile dependency * Disable this feature in itests Signed-off-by: Wouter Born <[email protected]>
wborn
added
patch
|
While not an issue persay, this seems to break the ability to create the hybrid 3.x 4.x jars. Noticed yesterday when compiling androidtv. |
|
That is to be expected and it will get more complicated over time as differences between branches grow. It's not recommended and unsupported for various reasons. |
|
Fully agreed and not trying to say we need to do anything to resolve it. Just noting for anyone who is doing the hybrids where the break occurred for later on. |
J-N-K
pushed a commit
to openhab/openhab-addons
that referenced
this pull request
Aug 13, 2023
This prevents ZipException stacktraces when running the itests on JDK 17.0.8 or newer. Related to: * openhab/openhab-core#3718 * openhab/openhab-core#3747 Signed-off-by: Wouter Born <[email protected]>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/no-longer-able-to-build-a-binding-for-3-4-x/149270/4 |
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Sep 29, 2023
) This prevents ZipException stacktraces when running the itests on JDK 17.0.8 or newer. Related to: * openhab/openhab-core#3718 * openhab/openhab-core#3747 Signed-off-by: Wouter Born <[email protected]>
austvik
pushed a commit
to austvik/openhab-addons
that referenced
this pull request
Mar 27, 2024
) This prevents ZipException stacktraces when running the itests on JDK 17.0.8 or newer. Related to: * openhab/openhab-core#3718 * openhab/openhab-core#3747 Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some more build issues due to this "Improved ZIP64 Extra Field Validation" (see #3718) now that Temurin 17.0.8 upgrades are available in APT repos.
The org.openhab.core.karaf bundle fails to build as Java thinks there are some issues with org.apache.karaf.features.core-4.4.0.jar. However
zip -T ...thinks it's OK. So perhaps this is a false positive. It doesn't complain about org.apache.karaf.features.core-4.4.3.jar so let's use that instead.Also the itests generate lots of ZipException stacktraces due to the issue with geronimo-osgi-locator.jar.