Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve state generation logic when fetching icons #3456

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Improve state generation logic when fetching icons #3456

merged 4 commits into from
Aug 31, 2023

Commits on Aug 31, 2023

  1. Add support for 'staticIcon' widget parameter 

    If set, icon state should not be included when fetching the icon for a
given widget.

See openhab#3404

Signed-off-by: Danny Baumann <[email protected]>
    @maniac103
    maniac103 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    a3979dd View commit details
    Browse the repository at this point in the history

  2. Use number format pattern for formatting state for icon URL 

    See openhab#3404

Signed-off-by: Danny Baumann <[email protected]>
    @maniac103
    maniac103 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    e973eb2 View commit details
    Browse the repository at this point in the history

  3. Simplify icon state selection logic 

    Signed-off-by: Danny Baumann <[email protected]>
    @maniac103
    maniac103 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    9dfa34f View commit details
    Browse the repository at this point in the history

  4. Send NULL state as 'null' when requesting icons 

    BasicUI set a predecent for doing so, and users are relying on that
behavior.

Fixes openhab#3461

Signed-off-by: Danny Baumann <[email protected]>
    @maniac103
    maniac103 committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    84026b7 View commit details
    Browse the repository at this point in the history