Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[awattar] Fix last hour not being considered for best price #17731

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Nov 11, 2024

Resolves #17316
Regression of #16871

@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Nov 11, 2024
@jlaur jlaur added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Nov 11, 2024
@jlaur jlaur removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Nov 13, 2024
@lsiepel lsiepel merged commit 772026e into openhab:main Nov 13, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Nov 13, 2024
@jlaur
Copy link
Contributor Author

jlaur commented Nov 13, 2024

@lsiepel - we should probably backport this to 4.2.x, since the regression was introduced there.

@lsiepel
Copy link
Contributor

lsiepel commented Nov 13, 2024

Yes, feel free to do so.
I think there will be one 4.2.x release before 4.3.0

@jlaur jlaur deleted the 17316-awattar-last-hour branch November 13, 2024 15:49
jlaur added a commit to jlaur/openhab-addons that referenced this pull request Nov 14, 2024
lsiepel pushed a commit that referenced this pull request Nov 15, 2024
@lsiepel lsiepel added the patch A PR that has been cherry-picked to a patch release branch label Nov 15, 2024
tl-photography pushed a commit to tl-photography/openhab-addons that referenced this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aWATTar] Bestprice items are set to UNDEF at 0 a.m.
3 participants