-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[awattar] Fix last hour not being considered for best price #17731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaur
added
bug
An unexpected problem or unintended behavior of an add-on
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
labels
Nov 11, 2024
Resolves openhab#17316 Signed-off-by: Jacob Laursen <[email protected]>
jlaur
force-pushed
the
17316-awattar-last-hour
branch
from
November 11, 2024 08:34
71d64e2
to
3d470c8
Compare
jlaur
added
rebuild
Triggers Jenkins PR build
and removed
rebuild
Triggers Jenkins PR build
labels
Nov 11, 2024
tl-photography
approved these changes
Nov 11, 2024
jlaur
removed
the
additional testing preferred
The change works for the pull request author. A test from someone else is preferred though.
label
Nov 13, 2024
lsiepel
approved these changes
Nov 13, 2024
@lsiepel - we should probably backport this to 4.2.x, since the regression was introduced there. |
Yes, feel free to do so. |
jlaur
added a commit
to jlaur/openhab-addons
that referenced
this pull request
Nov 14, 2024
Backport of openhab#17731 Signed-off-by: Jacob Laursen <[email protected]>
lsiepel
pushed a commit
that referenced
this pull request
Nov 15, 2024
Backport of #17731 Signed-off-by: Jacob Laursen <[email protected]>
lsiepel
added
the
patch
A PR that has been cherry-picked to a patch release branch
label
Nov 15, 2024
tl-photography
pushed a commit
to tl-photography/openhab-addons
that referenced
this pull request
Nov 15, 2024
Resolves openhab#17316 Signed-off-by: Jacob Laursen <[email protected]> Signed-off-by: Thomas Leber <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17316
Regression of #16871