Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[unifi] Provide LED channel for access point #17702

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Nov 5, 2024

Adds new channels for controlling LED on access point

This is a simplified version replacing #17534 since color and brightness seems unsupported on all tested access points, even though exposed by the API (and setable):

"led_override_color": "#0000ff",
"led_override": "default",
"led_override_color_brightness": 100,

led_override can be on, off or default. After using this channel, it will be either on or off and can not be set to default by the binding. This behavior is the same as in the UniFi app for Android. default means using the site-wide setting for LED.

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label Nov 5, 2024
@jlaur jlaur marked this pull request as ready for review November 5, 2024 19:53
@jlaur
Copy link
Contributor Author

jlaur commented Nov 5, 2024

@DrRSatzteil - perhaps you'd like to have a look?

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/ubiquiti-unifi-binding-feature-discussion/14520/1312

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM. Lets give some time for others to comment.

Copy link
Contributor

@DrRSatzteil DrRSatzteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsiepel lsiepel merged commit 6d9cc49 into openhab:main Nov 7, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.3 milestone Nov 7, 2024
@jlaur jlaur deleted the unifi-led branch November 8, 2024 22:42
KaaNee pushed a commit to KaaNee/openhab-addons that referenced this pull request Nov 8, 2024
* Provide LED channel for access

Signed-off-by: Jacob Laursen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants