Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[visualcrossing] Initial contribution #17239

Merged
merged 47 commits into from
Aug 29, 2024
Merged

[visualcrossing] Initial contribution #17239

merged 47 commits into from
Aug 29, 2024

Conversation

magx2
Copy link
Contributor

@magx2 magx2 commented Aug 12, 2024

Initial release of visualcrossing addon

@magx2 magx2 requested a review from a team as a code owner August 12, 2024 18:33
@lsiepel
Copy link
Contributor

lsiepel commented Aug 12, 2024

I thought you said you were done for this year 😆 Happy to see you continue to contribute though!

@jlaur jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Aug 13, 2024
@magx2
EVERYTHING
e14553d 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
i8n + format
63ba0b8 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
proper channles
3c6c411 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
return undefs
3523eea 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
proper solar energy unit
f78509f 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
more code
f3982d2 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
i8n
7b5533a 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
add visualcrossing to addons
6a62d0a 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
add visualcrossing to addons
1aa0278 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
channels
2708d70 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
locale/location
3b6e500 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
locale/location
866d4c3 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2 magx2 requested a review from lsiepel August 13, 2024 22:25
@magx2
allow to pick languages from list
392fa94 
Signed-off-by: Martin Grześlowski <[email protected]>
@lsiepel lsiepel changed the title [visualcrossing] Initial release [visualcrossing] Initial contribution Aug 19, 2024
lsiepel
lsiepel requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again! Binding is in a good shape already. Left questions and comments. I have 2 files to look at (Handler + channel-types.xml) in more detail. We probably only need 1 or 2 more iterations after these comments are addressed.

bundles/org.openhab.binding.visualcrossing/src/main/resources/OH-INF/addon/addon.xml Show resolved Hide resolved
bundles/org.openhab.binding.visualcrossing/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.visualcrossing/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.visualcrossing/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.visualcrossing/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.visualcrossing/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.visualcrossing/src/main/resources/OH-INF/thing/channel-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.visualcrossing/src/main/resources/OH-INF/thing/channel-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.visualcrossing/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.visualcrossing/README.md Outdated Show resolved Hide resolved
magx2 and others added 9 commits August 22, 2024 21:39
@magx2 @lsiepel
readme
c3ed92e 
Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Martin <[email protected]>
@magx2 @lsiepel
Update bundles/org.openhab.binding.visualcrossing/README.md
f40d8ed 
Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Martin <[email protected]>
@magx2 @lsiepel
Update bundles/org.openhab.binding.visualcrossing/src/main/java/org/o…
51e1ee7 
…penhab/binding/visualcrossing/internal/VisualCrossingHandlerFactory.java

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Martin <[email protected]>
@magx2 @lsiepel
Update bundles/org.openhab.binding.visualcrossing/src/main/resources/…
b46f729 
…OH-INF/thing/channel-types.xml

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Martin <[email protected]>
@magx2
remarks
c9ced42 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
current-conditions
c665632 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2 @lsiepel
Update bundles/org.openhab.binding.visualcrossing/README.md
8044381 
Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Martin <[email protected]>
@magx2
channel groups
9eb3baa 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2 @lsiepel
Update bundles/org.openhab.binding.visualcrossing/src/main/resources/…
cf0a58a 
…OH-INF/thing/thing-types.xml

Co-authored-by: lsiepel <[email protected]>
Signed-off-by: Martin <[email protected]>
@magx2
Revert "Remove *-epoch for sunrise and sunset"
9dd23fc 
This reverts commit cd0e0e7.

Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
proer handle of date time
8e10ae1 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
proper counting of humidity
b1395f8 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
configure channels
5f9dc2f 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
add example configuration
a7334a8 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
remarks
d6047f4 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
remarks
19b7497 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
remarks
ce99f44 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
rewrite description
1a02b95 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2 magx2 requested a review from lsiepel August 27, 2024 19:58
@lsiepel
Copy link
Contributor

lsiepel commented Aug 28, 2024

These are the two last comments for a merge. :-)

@magx2 magx2 requested a review from lsiepel August 28, 2024 20:33
@magx2
remove full_example.items
fb9f495 
Signed-off-by: Martin Grześlowski <[email protected]>
@magx2
properties
e5e132c 
Signed-off-by: Martin Grześlowski <[email protected]>
@lsiepel lsiepel merged commit f438468 into openhab:main Aug 29, 2024
4 of 5 checks passed
@magx2
Copy link
Contributor Author

magx2 commented Aug 29, 2024

@lsiepel thanks and see you next time :D!

@lsiepel
Copy link
Contributor

lsiepel commented Aug 29, 2024

You know the next step, you could add your binding's logo to the openHAB website. See https://next.openhab.org/docs/developer/addons/#add-your-add-on-s-logo-to-the-openhab-website-and-the-ui

cheers ;-)

digitaldan pushed a commit to digitaldan/openhab-addons that referenced this pull request Aug 29, 2024
@magx2 @digitaldan
[visualcrossing] Initial contribution (openhab#17239)
f95b0d1 
* EVERYTHING

Signed-off-by: Martin Grześlowski <[email protected]>
pgfeller pushed a commit to pgfeller/openhab-addons that referenced this pull request Sep 29, 2024
@magx2 @pgfeller
[visualcrossing] Initial contribution (openhab#17239)
96f25f6 
* EVERYTHING

Signed-off-by: Martin Grześlowski <[email protected]>
Signed-off-by: Patrik Gfeller <[email protected]>
joni1993 pushed a commit to joni1993/openhab-addons that referenced this pull request Oct 15, 2024
@magx2 @joni1993
[visualcrossing] Initial contribution (openhab#17239)
513b6ee 
* EVERYTHING

Signed-off-by: Martin Grześlowski <[email protected]>
matchews pushed a commit to matchews/openhab-addons that referenced this pull request Oct 18, 2024
@magx2 @matchews
[visualcrossing] Initial contribution (openhab#17239)
7cba4f2 
* EVERYTHING

Signed-off-by: Martin Grześlowski <[email protected]>
@wborn wborn added this to the 4.3 milestone Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsiepel lsiepel lsiepel approved these changes

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
4 participants
@magx2 @lsiepel @wborn @jlaur