-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct monthly sampling in Energy_signature.ipynb #176
Merged
saroele
merged 10 commits into
opengridcc:develop
from
saroele:issue172_multivarregression
Feb 12, 2017
Merged
Correct monthly sampling in Energy_signature.ipynb #176
saroele
merged 10 commits into
opengridcc:develop
from
saroele:issue172_multivarregression
Feb 12, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@JrtPec bump |
I propose to merge this branch. The multi-variable regression will still evolve and improve a lot, but no need to keep it separated from the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JrtPec I found a major bug in the Energy_signature notebook and tested different ways of solving it.
Please have a look at the different generators.
I'm in favour of using the 4th and even improving it so it doesn't bug when we put diff=True because of the unit conversion. Therefore, I created a milestone: https://github.com/opengridcc/opengrid/milestone/4 to group a few improvements. #173 is handled in this commit, others to be tackled.