Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct monthly sampling in Energy_signature.ipynb #176

Merged
merged 10 commits into from
Feb 12, 2017

Conversation

saroele
Copy link
Member

@saroele saroele commented Dec 18, 2016

@JrtPec I found a major bug in the Energy_signature notebook and tested different ways of solving it.
Please have a look at the different generators.

I'm in favour of using the 4th and even improving it so it doesn't bug when we put diff=True because of the unit conversion. Therefore, I created a milestone: https://github.com/opengridcc/opengrid/milestone/4 to group a few improvements. #173 is handled in this commit, others to be tackled.

@coveralls
Copy link

coveralls commented Dec 18, 2016

Coverage Status

Coverage decreased (-0.05%) to 70.088% when pulling 302522b on saroele:issue172_multivarregression into ccf995a on opengridcc:develop.

@saroele
Copy link
Member Author

saroele commented Jan 19, 2017

@JrtPec bump
I'll continue developing in this branch for now. Can you check out the bugs I solved and the solution I propose? Tnx

@coveralls
Copy link

coveralls commented Jan 19, 2017

Coverage Status

Coverage decreased (-0.3%) to 69.446% when pulling 2993238 on saroele:issue172_multivarregression into f059fdd on opengridcc:develop.

@coveralls
Copy link

coveralls commented Jan 19, 2017

Coverage Status

Coverage decreased (-0.3%) to 69.446% when pulling 35de4a7 on saroele:issue172_multivarregression into f059fdd on opengridcc:develop.

@saroele
Copy link
Member Author

saroele commented Feb 2, 2017

I propose to merge this branch. The multi-variable regression will still evolve and improve a lot, but no need to keep it separated from the develop branch.

@coveralls
Copy link

coveralls commented Feb 2, 2017

Coverage Status

Coverage decreased (-0.05%) to 69.446% when pulling cf9e81c on saroele:issue172_multivarregression into 3165cda on opengridcc:develop.

@saroele saroele merged commit dc8c6ef into opengridcc:develop Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants