Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLU-328: refactor page titles #758

Open
wants to merge 4 commits into
base: chore/filter-tiles
Choose a base branch
from

Conversation

pregnantboy
Copy link
Contributor

@pregnantboy pregnantboy commented Oct 2, 2024

Changes

  • refactor existing pages to use shared compoenents PageTitle, DebouncedSearchInput and usePaginationAndFilter
  • move hamburger menu for small devices to replace plumber logo
  • fix some css styling

Copy link
Contributor Author

pregnantboy commented Oct 2, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @pregnantboy and the rest of your teammates on Graphite Graphite

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 2, 2024

Datadog Report

Branch report: chore/refator-page-titles
Commit report: 99ede51
Test service: plumber

✅ 0 Failed, 703 Passed, 0 Skipped, 2m 5.82s Total Time
➡️ Test Sessions change in coverage: 1 no change

@pregnantboy pregnantboy marked this pull request as ready for review October 3, 2024 06:25
@pregnantboy pregnantboy requested a review from a team as a code owner October 3, 2024 06:25
@pregnantboy pregnantboy changed the title chore: refactor page titles PLU-328: refactor page titles Oct 9, 2024
Copy link

linear bot commented Oct 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant