fix: wrong desc when residentialstatus is code=C #637
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Citizen
, but production sgID response hasCITIZEN
CITIZEN
in the desc field for this case(I don't know if the other values like
PR
are correct. Also production sgID returnsNA
for foreigners, and notALIEN
, but mockpass doesn't have personas that reflect that right now and I'm not sure how the real Myinfo v3 handles it.)Solution
Bug Fixes:
Citizen
toCITIZEN
where residentialstatus has codeC
.