feat: add Datadog RUM to template and components #790
+79
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Datadog ReportBranch report: ✅ 0 Failed, 129 Passed, 23 Skipped, 31.39s Total Time |
adriangohjw
approved these changes
Oct 18, 2024
Comment on lines
+8
to
+24
| datadogRum.init({ | ||
| applicationId: PUBLIC_RUM_APPLICATION_ID, | ||
| clientToken: PUBLIC_DD_RUM_CLIENT_TOKEN, | ||
| site: "datadoghq.com", | ||
| service: "isomer-next-sites", | ||
| env: "production", | ||
| sessionSampleRate: Number( | ||
| process.env.NEXT_PUBLIC_ISOMER_NEXT_RUM_SAMPLING_RATE ?? 0, | ||
| ), | ||
| sessionReplaySampleRate: Number( | ||
| process.env.NEXT_PUBLIC_ISOMER_NEXT_RUM_SAMPLING_RATE ?? 0, | ||
| ), | ||
| trackUserInteractions: true, | ||
| trackResources: true, | ||
| trackLongTasks: true, | ||
| defaultPrivacyLevel: "allow", | ||
| }) |
There was a problem hiding this comment.
should we pass in production as ENV too? or check that its production/staging before rendering. so as to not dirty the data + not have it run on dev and incur unncessary cost
There was a problem hiding this comment.
ooo why this file will change ah?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't have RUM set up on our template, so we are not able to monitor the user behaviour on the actual Isomer Next sites.
Solution
Breaking Changes
Features:
NEXT_PUBLIC_ISOMER_NEXT_RUM_SAMPLING_RATE, which is injected at build time to feature flag the level of sampling.