fix(links): add validation to components that are links or refs #789
+94
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seaerchin
changed the base branch from
08/perms/error-boundary
to
feat/pdf-collections
Datadog ReportBranch report: ✅ 0 Failed, 129 Passed, 23 Skipped, 34.95s Total Time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We previously did not sanitise our URLs at all. this meant that we were allowign insecure URLs on our frontend/backend. in order to alleviate this as a first pass, i added regex validation
Solution
[...]), files (end in.pdf) and mails (begins withmailto:)switchstatement still renders the component (and triggers validation). using theifstatement doesn't render and has the desired behaviourScreenshots
Screen.Recording.2024-10-18.at.10.52.58.PM.mov