Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isom-1286 add indexes for tables #787

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

adriangohjw
Copy link
Contributor

Problem

Closes https://linear.app/ogp/issue/ISOM-1286/add-indexes-for-tables

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible

Improvements:

  • Removed 2 composite indexes from Resource as they are already covered and overlapping with another index
  • Added index on type for Resource

@adriangohjw adriangohjw self-assigned this Oct 18, 2024
@adriangohjw adriangohjw requested a review from a team as a code owner October 18, 2024 09:20
Copy link

linear bot commented Oct 18, 2024

Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 9:23am

@datadog-opengovsg
Copy link

datadog-opengovsg bot commented Oct 18, 2024

Datadog Report

Branch report: adriangohjw/isom-1286-add-indexes-for-tables
Commit report: 693217a
Test service: isomer-studio

✅ 0 Failed, 129 Passed, 23 Skipped, 29.99s Total Time
➡️ Test Sessions change in coverage: 1 no change

Copy link
Contributor

@seaerchin seaerchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. prisma indexes also have the sort option which might help for guaranteeing a stable retrieval order of items.

i was thinking we could index type, id then add the sort in but as a first pass this already looks good to me.

@adriangohjw
Copy link
Contributor Author

@seaerchin thanks for sharing!

yeah i think at current stage no need too much optimization - from experience, better to look at usage data. I have looked into AWS RDS and saw that we already have Performance Insights set up so lets monitor along

@adriangohjw adriangohjw merged commit 7614f36 into main Oct 18, 2024
18 of 19 checks passed
@adriangohjw adriangohjw deleted the adriangohjw/isom-1286-add-indexes-for-tables branch October 18, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants