chore(tests): add test descriptions for publishing #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
1 task
seaerchin
force-pushed
the
chore/publish-tests
branch
from
28aef12
to
e586c8a
Compare
Datadog ReportBranch report: ✅ 0 Failed, 129 Passed, 34 Skipped, 34.76s Total Time |
seaerchin
changed the title
seaerchin
force-pushed
the
chore/publish-tests
branch
from
e586c8a
to
1c5c21f
Compare
dcshzj
approved these changes
Oct 17, 2024
| @@ -887,7 +887,19 @@ describe("page.router", async () => { | |||
| }) | |||
|
|
|||
| // TODO: Implement tests when publish works | |||
| describe.skip("publishPage", () => {}) | |||
| describe.skip("publishPage", () => { | |||
| it.skip("should trigger a publish automatically on creation of a folder", () => {}) | |||
There was a problem hiding this comment.
nit: maybe can make it clearer that it is referring to implicit publishes? Same for the rest of the test cases
Suggested change
| it.skip("should trigger a publish automatically on creation of a folder", () => {}) | |
| it.skip("should trigger an implicit publish automatically on creation of a folder", () => {}) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
currently, we have no test descriptions for publishing. just adding this here so next time we're clear on what we have to verify for publishing
Solution
add tests for publishing