fix(folder): update the folder title to not be empty #750
+21
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we don't wnat to show both the url + the error cos it's redundant (invalid url)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Datadog ReportBranch report: ✅ 0 Failed, 8 Passed, 1 Skipped, 7.97s Total Time |
harishv7
approved these changes
Oct 9, 2024
seaerchin
deleted the
chin/isom-1622-edit-folder-settings-allows-empty-title
branch
seaerchin
added a commit
that referenced
this pull request
Oct 10, 2024
* fix: disable empty titles for folder modal * chore: update copy for page settings * fix: update mode for validation * fix: replace the url field if there is an error we don't wnat to show both the url + the error cos it's redundant (invalid url) * fix: import the correct error message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
onChange- this is because validation (by default) for react hook form starts after submit, which won't be true for our modal (we close after a successful submit)Screenshots
Screen.Recording.2024-10-09.at.7.04.46.PM.mov