feat: add Table component and styling #238
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for objective-bell-0ffbfb canceled.
|
seaerchin
reviewed
May 12, 2023
| ) | ||
| } | ||
|
|
||
| const INTERACTIVE_PSEUDO_PROPS = ['_active', '_hover', '_pressed', '_selected'] |
There was a problem hiding this comment.
is _focus not included here? from mdn docs, it seems to be interactable (also, should we base this off the mdn one?)
| export function omitInteractivePseudos( | ||
| props: InteractableProps, | ||
| styles: SystemStyleObject, | ||
| ): SystemStyleObject { |
There was a problem hiding this comment.
nit: look like low hanging fruit to do Omit<SystemStyleObject, InteractableProps>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #237
More of styling of cells and headers