[ux] Use a combobox to edit sslmode setting #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gacarrillor
commented
Jul 11, 2024
| @@ -85,6 +88,9 @@ def data(self, index, role=Qt.ItemDataRole.DisplayRole): | |||
| or self.__model_data[key] != self.__original_data[key] | |||
| ): | |||
| return QColorConstants.DarkGreen | |||
| elif role == Qt.ItemDataRole.UserRole: | |||
| if index.column() == self.VALUE_COL and key == self.SSLMODE_KEY: | |||
| return {key: [e.value for e in SslModeEnum]} | |||
There was a problem hiding this comment.
Looking at it, I guess this list could be created at pg_service_parser/conf/service_settings.py, and assign it to the "values" key, instead of assigning the whole SslModeEnum.
gacarrillor
commented
Jul 11, 2024
| "description": "This option determines whether or with what priority a secure SSL TCP/IP connection will be negotiated with the server.", | ||
| "values": SslModeEnum, |
There was a problem hiding this comment.
We could also add tooltips for each value here, perhaps as a separate key (e.g., "value_tooltips") and assign a list of tooltips.
Now, this dict is growing as you said, we could perhaps address this in a follow-up PR later (I'll wait for your instructions regarding that).
3nids
approved these changes
Jul 16, 2024
3nids
approved these changes
Jul 16, 2024
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #42