Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure QGIS can reload the underlying lib #34

Merged
merged 1 commit into from
May 27, 2024
Merged

Make sure QGIS can reload the underlying lib #34

merged 1 commit into from
May 27, 2024

Conversation

gacarrillor
Copy link
Contributor

Add __init__.py to libs/ so that QGIS understands we've got a subpackage in libs/ and can reload it when reloading or upgrading the plugin.

Fix #33

…age in libs and can reload it when reloading or upgrading the plugin
@gacarrillor
Copy link
Contributor Author

Steps to reproduce the solution to the problem:
(see steps to reproduce the problem)

  1. Download pg_service_parser.0.1.7_mod.zip (this version writes whitespaces between the = sign in the pg_service.conf file), BUT, it has a libs/__init__.py file to let QGIS know we've got a package it has to unload when unloading the plugin.
  2. Install the ZIP from 1) and make sure it is activated (i.e., that you see the plugin icon in the plugins toolbar).
  3. Use the plugin to write on the pg_service.conf file.
  4. Verify the spaces between the = sign. This is expected.
  5. Go to Plugin Manager -> All, search for pg service. Select the plugin from the list and click on Upgrade plugin.
  6. Repeat step 3).
  7. THIS TIME you won't get spaces between the = sign, which is the behavior we expect since 0.1.9 (the one the plugin was upgraded to) already has a fix for that.

@3nids 3nids merged commit a19d57a into main May 27, 2024
3 checks passed
@gacarrillor gacarrillor deleted the reload_lib branch May 27, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reloading the plugin should also reload the underlying lib
2 participants