Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI/UX] Highlight edited service entries #25

Merged
merged 3 commits into from
May 3, 2024
Merged

Conversation

gacarrillor
Copy link
Contributor

@gacarrillor gacarrillor commented May 2, 2024

Fix #23

vokoscreenNG-2024-05-02_16-57-39.mp4

Features:

  • Edited entry is highlighted in red and italics.
  • An edited entry leads to enable the Update service button.
  • Reedited values that return to their original stored value, go back to initial state (black and no italics). If the reedited value makes all values correspond to their original state, the Update service button is disabled, since there's nothing to save.
  • Once edited values are saved, they go back to initial state (black and no italics) and the Update service button gets disabled.

@gacarrillor
Copy link
Contributor Author

@3nids, please help me testing this PR.

BTW, isn't red a bit too strong for users? It might convey the message that something is wrong with the new value.
Do you know if we use this approach elsewhere in QGIS?

@3nids
Copy link
Member

3nids commented May 2, 2024

Yep, you're right, maybe blue or green would be more appropriate.

@gacarrillor
Copy link
Contributor Author

Yep, you're right, maybe blue or green would be more appropriate.

Let's set it to dark green then (normal green was too light).

image

@gacarrillor gacarrillor merged commit 074cc87 into main May 3, 2024
3 checks passed
@gacarrillor gacarrillor deleted the highlight_changes branch May 3, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

edited service should be highlighted
2 participants