Update base lib and adapt the plugin to it #12
Conversation
| @@ -51,24 +37,22 @@ def create_service( | |||
| config.write(f) | |||
|
|
|||
| if service_name in config: | |||
| return write_service_settings(service_name, settings) | |||
| pgserviceparser.write_service(service_name, settings) | |||
| return True | |||
|
|
|||
| return False | |||
|
|
|||
|
|
|||
| def copy_service_settings( | |||
There was a problem hiding this comment.
shouldn't we drop the other methods (which are direct wrappers) and keep only this one?
There was a problem hiding this comment.
Yes, we could do it. My original intention was to keep the dialog away from the lib, and let it talk only with the wrapper, so as to do in the wrapper whatever adjustment we could eventually need.
If we remove the other methods, we'll have the dialog connected to both lib and wrapper, which is also possible. If that's fine for you, I'll proceed to remove them.
There was a problem hiding this comment.
my original thought was to reduce the amount of code, but do as you think it's best.
There was a problem hiding this comment.
OK, let's leave it as it is for now and see how it evolves: if we need another direct link from the dialog to the lib for any reason, we'll remove all other methods from the wrapper. 👍
No description provided.