Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add the /api/v1 if not reneeded #607

Merged
merged 6 commits into from
Nov 18, 2024

Conversation

edouardbruelhart
Copy link
Contributor

Here I propose to ignore paths that start with "/api" or that are equal to "/" to remove unnecessary parts, but to keep other ones to avoid 404 errors.

@suricactus
Copy link
Collaborator

This PR fixes #605 (comment)

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! It seems I never published my review...

Happy to merge once we fix the comments!

qfieldsync/core/cloud_api.py Outdated Show resolved Hide resolved
qfieldsync/core/cloud_api.py Outdated Show resolved Hide resolved
@suricactus suricactus self-requested a review November 12, 2024 20:00
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, also if you can run pre-commit to make the code checks happy.

Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@suricactus suricactus merged commit c70e6b5 into opengisch:master Nov 18, 2024
7 checks passed
@suricactus suricactus changed the title correction poposition for issue 605 Do not add the /api/v1 if not reneeded Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants