-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not add the /api/v1
if not reneeded
#607
Conversation
This PR fixes #605 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! It seems I never published my review...
Happy to merge once we fix the comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, also if you can run pre-commit
to make the code checks happy.
Correction by suricactus Co-authored-by: Ivan Ivanov <[email protected]>
corrected by suricactus Co-authored-by: Ivan Ivanov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/api/v1
if not reneeded
Here I propose to ignore paths that start with "/api" or that are equal to "/" to remove unnecessary parts, but to keep other ones to avoid 404 errors.