Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Python Docstring #58

Merged
merged 25 commits into from
Sep 8, 2024
Merged

Adding Python Docstring #58

merged 25 commits into from
Sep 8, 2024

Conversation

SeqLaz
Copy link
Member

@SeqLaz SeqLaz commented Aug 29, 2024

No description provided.

@SeqLaz SeqLaz requested a review from suricactus August 29, 2024 12:47
suricactus
suricactus reviewed Aug 30, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 30, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 30, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 30, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 30, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 30, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 30, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 30, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 31, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 31, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 31, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Aug 31, 2024
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go over the whole docs once again, as the coments I made were not always properly aligned. Please squash and force push a single commit.

@SeqLaz SeqLaz force-pushed the upstreaming-docs-in-sdk branch 2 times, most recently from f2217c8 to 3979a80 Compare August 31, 2024 15:52
@SeqLaz SeqLaz force-pushed the upstreaming-docs-in-sdk branch from f03a70b to 182514a Compare August 31, 2024 16:53
nirvn
nirvn reviewed Sep 2, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
qfieldcloud_sdk/sdk.py Show resolved Hide resolved
qfieldcloud_sdk/sdk.py Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
@suricactus @nirvn
Apply suggestions from code review
f315962 
Co-authored-by: Mathieu Pellerin <[email protected]>
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
suricactus
suricactus reviewed Sep 3, 2024
View reviewed changes
qfieldcloud_sdk/sdk.py Outdated Show resolved Hide resolved
SeqLaz and others added 21 commits September 3, 2024 15:39
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
aeef2ca 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
a18a377 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
9a270f8 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
6111025 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
3790687 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
2caeba5 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
cdba478 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
4d2dbf9 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
bf1bd24 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
13fdb04 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
f534b1f 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
cde554f 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
bdb9096 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
be7994d 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
72ee767 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
a03928c 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
7199e3d 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
e450a20 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
99bdbee 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz @suricactus
Update qfieldcloud_sdk/sdk.py
66338f3 
Co-authored-by: Ivan Ivanov <[email protected]>
@SeqLaz
Updating list and dic
db5b090
@suricactus
Copy link
Collaborator

Let's merge for now!

@suricactus suricactus merged commit 2651eca into master Sep 8, 2024
4 checks passed
@suricactus suricactus deleted the upstreaming-docs-in-sdk branch September 8, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suricactus suricactus suricactus left review comments

@nirvn nirvn nirvn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SeqLaz @suricactus @nirvn