Get and reset T_Id Sequence #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ater is the plugin and this is the library
|
Upsi. Wrong model in pg test. Will fix it... |
domi4484
approved these changes
Nov 17, 2023
domi4484
approved these changes
Nov 24, 2023
| ).format(value) | ||
| except pyodbc.errors.Error as e: | ||
| error_message = " ".join(e.args) | ||
| return False, self.tr("Could not reset sequence: {}").format( |
There was a problem hiding this comment.
Would not be better to throw an exception instead of returning false? I'm thinking more general that only this case. Or is it a design décision for the library?
There was a problem hiding this comment.
Oopsi. Haven't seen this before merging. Good input, but I wanted it to make it identical to other functions. Some (e.g.) create_baskets are called for multiple baskets, where in the frontend I 'collect' all the feedbacks and return it in a list. Kind of "5 of 10 baskets are not created" or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very powerful thingy that should be handled very carefully.
Reset the Sequences
GPKG
PG
Limitations or "What is with conflicts?"
GPKG
When resetting the value and then run into conflicts.
Because of the unique constraints it just counts it up - means it continues to work with the tablewide t_id (I guess it takes the Geopackage Function AUTOGENERATE)...
Our t_ili_tids are of course fucked up then...
On another table of course it works but on validation of course it has troubles then because of duplicates.
PG
Similar but not same on postgres. When resetting the sequence, it just counts up with it, but because of unique constraint it cannot store the feature.
On another table of course it works but on validation of course it has troubles then because of duplicates.