-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide OID domains per layers #68
Conversation
The changes on the class are not that big, in fact only a nice provide of the oid_domain (the type) and the t_ili_tid field (oid field). Then some tests and in the end kind of a proof of concept... |
@@ -341,6 +341,20 @@ def real_id(self): | |||
else: | |||
return None | |||
|
|||
@property | |||
def oid_domain(self): | |||
t_ili_tid_field = self.t_ili_tid_field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t_ili_tid_field = self.t_ili_tid_field | |
t_ili_tid_field = self.t_ili_tid_field() |
Missing parentheses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah no its a property...
Thanks @domi4484 I think here you would have already the basics for the GUI implementation. Maybe you will find some more requirements to it during implementation. I'll make a release of the library. |
This PR provides the OID domain (type) over the
Layer
object.This is the approach the Plugin using the
Generator
and not calling adb_connector
function directly. The reason is, to have the information about the relevance of a layer, alias (that will be used in the project later) etc. and we can set the default_expression directly.How I imagine it to work:
It's reloaded on changing the strategy - and the generator is persisted for further project generation:
0. getting the
Generator
and on changing the strategy in the GUI:
and getting the list of layers...
1. getting a list of the layers visible in the project (according to relevance and strategy) not concerning the system tables
2. Getting the oid type (and the other info)
3. Set the default_expressions
Limitations
If a CLASS is designed in a TOPIC (with ANYOID) and it's extended in multiple other TOPICS with different OID definitions, we cannot say what should be the default value. This is a known limitation or maybe we find a solution for it.