Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topping on create Project #858

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Topping on create Project #858

merged 9 commits into from
Dec 6, 2023

Conversation

signedav
Copy link
Member

@signedav signedav commented Dec 4, 2023

Topping on Generate

Get Topping of Metaconfig stored in the DB

Since ili2db 4.11 the id of the metaconfiguration file used to create the physical database is stored in the meta-tables. This means, on Project Creation we consider this id and provide the linked project topping.

Screenshot from 2023-12-04 14-41-47

Get Topping by selection

Still it's possible to disable it and choose another project topping file.

image

You can choose a project topping file (identified by model, db-type) from the UsabILITy Hub repositories or as well a YAML file from the local system.

Why, project topping file

... and not "metaconfiguration* file?

Because on this step only project topping files are relevant. Metaconfiguration files are only relevant, when the schema is created. We thought about to provide them, to choose the same like on schema import, but this part is already provided by getting the topping from the DB.

To do

  • preferredDataSource
  • Finetune GUI
  • Synchronize with other open PRs

Resolves #479 and resolves #768

Busy Bar

Not directly related to this topic but it popped up again. Sometimes the wizard has to load - mostly checking the repos to suggest data / reload the comboboxes. And there users are confused, what's happening. For this reason it does now:

  • Disable the Wizard Page (not cancel button)
  • Showing a busy bar...
Screencast.from.04.12.2023.16.24.24.webm

Screenshot from 2023-12-08 13-50-00

… we provide it to the gui.

we can disable the metaconfig from the database and select another project topping from the usabilityhub or from the local system.
when a topping is selected we disable the optimize strategy.
@signedav
Copy link
Member Author

signedav commented Dec 4, 2023

Any inputs on that @geckoGIS ?

@signedav signedav requested a review from domi4484 December 4, 2023 13:56
Copy link
Member

@domi4484 domi4484 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Just one question which code makes the progressbar moving? I can't see it :)

QgisModelBaker/gui/workflow_wizard/workflow_wizard.py Outdated Show resolved Hide resolved
@signedav
Copy link
Member Author

signedav commented Dec 4, 2023

Just one question which code makes the progressbar moving? I can't see it :)

That's pure magic 🧙 It's the QProgressBar.setRange(0,0) - Haven't knew it untill today neither...

@signedav signedav merged commit 737579b into master Dec 6, 2023
6 checks passed
@signedav signedav deleted the projecttopping branch December 6, 2023 09:01
@signedav signedav mentioned this pull request Mar 13, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Topping import for genrating projects from existing databases Toppings on Project Create
2 participants