Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set transaction mode as enum #856

Merged
merged 2 commits into from
Dec 1, 2023
Merged

set transaction mode as enum #856

merged 2 commits into from
Dec 1, 2023

Conversation

signedav
Copy link
Member

@signedav signedav commented Dec 1, 2023 •
edited
Loading

@signedav signedav requested a review from domi4484 December 1, 2023 13:05
domi4484
domi4484 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@domi4484 domi4484 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we define "AutomaticGroups", "Disable", and so on as const in the library instead of using the literals?

@signedav
Copy link
Member Author

signedav commented Dec 1, 2023

Yeah. or what do you think about Qgis.TransactionMode.AutomaticGroups.name?

@domi4484
Copy link
Member

domi4484 commented Dec 1, 2023

Yeah. or what do you think about Qgis.TransactionMode.AutomaticGroups.name?

yes even better!

@signedav signedav merged commit 95b31fd into master Dec 1, 2023
6 checks passed
@signedav signedav deleted the transactionmode branch December 1, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domi4484 domi4484 domi4484 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@signedav @domi4484