Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UsabILItyHub: Filter Toppings according to the Database Source #855

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

signedav
Copy link
Member

@signedav signedav commented Nov 30, 2023

In the ilidata it's the category with the key http://codes.modelbaker.ch/preferredDataSource describing what db the file is made for. If there is no such category it's always displayed.

Means on import

Filters UsabILIty Hub Metaconfig Files according to the current database.

Means on topping export

It detects what db sources are used and suggests you to optimize. But you can choose none - means the topping will be displayed on every db source...
Screenshot from 2023-12-01 09-09-18

Resolves #759

Depends on opengisch/QgisModelBakerLibrary#79

@signedav signedav changed the title Filter Toppings according to the Database Source UsabILItyHub: Filter Toppings according to the Database Source Dec 1, 2023
@signedav signedav requested a review from domi4484 December 1, 2023 10:43
@signedav
Copy link
Member Author

signedav commented Dec 1, 2023

I know this topic is a little bit special, but code review would be much appreciated @domi4484

@sjib
Copy link

sjib commented Dec 1, 2023

Screenshot from 2023-12-01 09-09-18

Suggested change in explanation on wizard window - rephrasing:
"These are the models for which metaconfigurations / toppings are available on the Usability Hub. Select the models wanted!"

and
"Filtering by type of topping. Choose 'none' to allow all."

@signedav
Copy link
Member Author

signedav commented Dec 1, 2023

@sjib Thanks. I did not take your suggestions directly but improved mine accordingly.

@signedav signedav merged commit f042415 into master Dec 1, 2023
6 checks passed
@signedav signedav deleted the toppinglayer-identificator-docs branch December 1, 2023 13:04
@signedav signedav mentioned this pull request Mar 13, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toppings: Possible incompatibilities (gpkg/postgis)
3 participants