-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRS spec definition for version 0.1 #25
Merged
+39
−16
Merged
Changes from 11 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
2ddcb90
CRS spec definition for version 0.1
alasarr 4cdc908
Links for CRS
alasarr fc13fd9
Back to EPSG:4326
alasarr 15e3fa0
Update format-specs/geoparquet.md
alasarr 9aebaa3
Update format-specs/geoparquet.md
alasarr a15b1ac
Update format-specs/geoparquet.md
alasarr 6caeda0
Update format-specs/geoparquet.md
alasarr dfddc3e
Update format-specs/geoparquet.md
alasarr 6462514
Update format-specs/geoparquet.md
alasarr a4db6c3
Update format-specs/geoparquet.md
alasarr 152fb6b
WKT2 link
alasarr 4e80aab
Update format-specs/geoparquet.md
alasarr cc7ae18
Update format-specs/geoparquet.md
alasarr b4f956c
Update format-specs/geoparquet.md
alasarr 8ce7812
Update format-specs/geoparquet.md
alasarr beafe33
Update format-specs/geoparquet.md
alasarr ea0bf1b
Link to epsg.org
alasarr 6fd384d
Merge branch 'alasarr/crs' of github.com:opengeospatial/geoparquet in…
alasarr 869f335
Update format-specs/geoparquet.md
jorisvandenbossche 981fca7
Update format-specs/geoparquet.md
jorisvandenbossche 44dca93
undo change in example to avoid conflicts
jorisvandenbossche aedb19b
Only support WKT2 2019
alasarr de792bf
Update format-specs/geoparquet.md
alasarr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we should mention here that our axis order overrides this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already have a specific section for coordinate order where we specify that. Did you see it? Or do you just want to emphasize here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I saw it - I think we can refer to that section. I just think we need to call it out here. Acknowledge it's a bit confusing. We say here 'use the crs for latitude/longitude', and then below we say 'but do it as longitude/latitude'.
I suppose alternatively we don't actually mention lat/long or or long/lat here - we just that we recommend 4326 for widest interoperability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see your point now 👍