Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert changes to fix CI #219

Merged
merged 1 commit into from
May 20, 2024
Merged

Revert changes to fix CI #219

merged 1 commit into from
May 20, 2024

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented May 19, 2024 •
edited
Loading

Reverting the recent CI breaking changes for now to unblock other PRs.

The changes that we revert here are preserved via #220

@m-mohr
Revert "Migration of the GeoParquet specification to the official OGC…
6e01093 
… document template (#206)"

This reverts commit 5d67a9c.
Revert "Update README.md (#214)"

This reverts commit 471a2f8.
Revert "Updated the list of submitting organizations"

This reverts commit 2aa0668.
Revert "Updated the list of Submitting Organizations"

This reverts commit a727140.
@m-mohr m-mohr force-pushed the revert-template branch from a730590 to 6e01093 Compare May 19, 2024 12:10
@m-mohr m-mohr mentioned this pull request May 19, 2024
Closed
cholmes
cholmes approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@cholmes cholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reverting this. Let's at least get in the notification that it's a draft spec in soon - I'll make a PR for that. And I'll work on a PR to get this back in to the repo, but not breaking the build and confusing people with the readme template.

@cholmes cholmes merged commit fcb3b3a into main May 20, 2024
2 checks passed
@cholmes cholmes deleted the revert-template branch May 20, 2024 02:42
@cholmes
Copy link
Member

cholmes commented May 20, 2024

And I'll work on a PR to get this back in to the repo,

And of course @m-mohr already has a PR ready at #220 :) Thanks!

@m-mohr
Copy link
Collaborator Author

m-mohr commented May 20, 2024 •
edited
Loading

Not quite, #220 is the full set of changes from Gobe with the breaking change. We should probably cherry pick the Markdown changes that add the note from there. Can do it later...

@m-mohr
Copy link
Collaborator Author

m-mohr commented May 20, 2024

... Or we just use #205

@m-mohr m-mohr mentioned this pull request May 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cholmes cholmes cholmes approved these changes

@tschaub tschaub tschaub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-mohr @cholmes @tschaub