-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Media Type #213
Merged
Merged
Added Media Type #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in #115
m-mohr
reviewed
May 6, 2024
Closed
cholmes
commented
May 6, 2024
m-mohr
reviewed
May 6, 2024
Co-authored-by: Matthias Mohr <[email protected]>
cholmes
commented
May 6, 2024
m-mohr
approved these changes
May 6, 2024
kylebarron
approved these changes
May 6, 2024
jorisvandenbossche
approved these changes
May 7, 2024
CI is currently broken from #214 |
CI has been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added application/vnd.apache.parquet as the media type, as discussed in #115
Like #212 I went with no 'justification' as to why we don't have a 'geo' type, but could add that in.
This is likely not the right organizational structure, but working to get the PR in, and then we can revisit where it goes.