-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional column metadata field to store bounding box information #21
Optional column metadata field to store bounding box information #21
Conversation
Co-authored-by: Brendan Ward <[email protected]>
I added this "formatted according to RFC 7946, section 5" (i.e. GeoJSON), copying how this "bbox" was specified in the STAC Item schema: https://github.com/radiantearth/stac-spec/blob/master/item-spec/item-spec.md#item-fields However, I am not 100% sure we actually want to fully follow that:
|
I'm not sure exactly how we relate it, but I do think we should explicitly mention the interaction between that geodesic=true/false and the bounding box - if that field changes the interpretation of anything here.
Wow, I've read that spec a number of times and never even noticed this. I feel ok with just referencing the spec and not trying to clarify this particular issue. If someone actually has a problem with it then we could redo it. But I think it's nice to be able to point at something else that has lots of parsers written for it, instead of making people carefully read ours and try to do something slightly different. |
👍 , just saw this for the first time!
My read of this is: in each of those examples,
My read of that is that if you had a bounding box to cover the globe above [-180.0, 70, 180.0, 90.0] |
Indeed! By chatting with @paleolimbot about this, he mentioned the same. I completely missed this from an initial reading, but that makes sense now. So to follow up on my own questions:
That is consistent with how PROJ or S2 specify bounding boxes / areas (see also the comment at #8 (comment)).
This is actually fine, and isn't influenced by the
This is clarified above. In summary, I am now convinced it is good to specify this field follows the GeoJSON specification. |
* Adds `bbox`, consistent with #21 * Fixed the `pyarrow.parquet` import
Closes #8